Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort spectra by specific parameter #3272

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

hamed-musallam
Copy link
Member

@hamed-musallam hamed-musallam commented Oct 17, 2024

The spectra are sorting without mutating the original state

@hamed-musallam hamed-musallam linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb13b71
Status: ✅  Deploy successful!
Preview URL: https://a8d981ca.nmrium.pages.dev
Branch Preview URL: https://order-by-multiple-spectra-an.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the order-by-multiple-spectra-analysis branch from 68b1791 to 24295e7 Compare October 17, 2024 10:32
@hamed-musallam hamed-musallam linked an issue Oct 17, 2024 that may be closed by this pull request
@hamed-musallam hamed-musallam force-pushed the order-by-multiple-spectra-analysis branch 2 times, most recently from 3daa72b to 22c40f7 Compare October 18, 2024 07:03
@lpatiny
Copy link
Member

lpatiny commented Oct 18, 2024

Exporting the raw data is working perfectly.

Concerning sorting, is there any reason I can not sort by an integration value ?

image

@hamed-musallam
Copy link
Member Author

Exporting the raw data is working perfectly.

Concerning sorting, is there any reason I can not sort by an integration value ?

image

The way we sort the integration is different from how we sort the spectrum parameter.

@lpatiny
Copy link
Member

lpatiny commented Oct 18, 2024

Would it be possible to toggle between 3 states ? Sort up / Sort down / reset to original order.

Also would it be difficult to also add the sort by integral ?

2024-10-18 09 20 59

@hamed-musallam hamed-musallam force-pushed the order-by-multiple-spectra-analysis branch from 1b50177 to 76a6c67 Compare October 22, 2024 09:11
@hamed-musallam hamed-musallam force-pushed the order-by-multiple-spectra-analysis branch from b75bf43 to 503b3de Compare October 22, 2024 09:17
@hamed-musallam hamed-musallam force-pushed the order-by-multiple-spectra-analysis branch from 503b3de to cb13b71 Compare October 22, 2024 09:21
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM

@hamed-musallam hamed-musallam merged commit c807446 into main Oct 22, 2024
12 checks passed
@hamed-musallam hamed-musallam deleted the order-by-multiple-spectra-analysis branch October 22, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy raw values Order by in multiple spectra analysis
2 participants